Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Frame Advance #8939

Merged
merged 6 commits into from
Aug 30, 2016
Merged

Add Frame Advance #8939

merged 6 commits into from
Aug 30, 2016

Conversation

RisingFog
Copy link
Contributor

@RisingFog RisingFog commented Aug 28, 2016

This adds preliminary support for Frame Advance within PPSSPP. For some reason, there's a lot of extra changes in regards to whitespaces, not sure why.

if (frameStep_)
{
frameStep_ = false;
Core_EnableStepping(true);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, in EmuScreen this might actually be a better place:

https://github.com/RisingFog/ppsspp/blob/842a29b0aedd2e5db59128f3b25b06d803d27386/UI/EmuScreen.cpp#L980

This will be once per displayed frame though, so importantly:

  • If frameskip is enabled, it will not happen for skipped frames.
  • If the game runs at 30fps, it will be at 30fps.

-[Unknown]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't get it to update the screen properly while frame advancing.

@unknownbrackets
Copy link
Collaborator

Looks okay to me, just needs static.

-[Unknown]

@hrydgard
Copy link
Owner

Functionality and idea seem fine to me, but is it possible to get out of the frame stepping state on Android, where you can't access the Run command from a menu?

If it's problematic on Android and other non-Win32 platforms, one option would be to only enable this feature on Windows until it can be solved.

@RisingFog
Copy link
Contributor Author

I've (hopefully) removed the option from mobile devices.

@hrydgard
Copy link
Owner

There are still some platforms that are not mobile but don't have a menu, like the SDL Mac build, but meh. Thanks!

@hrydgard hrydgard merged commit 9e70a6f into hrydgard:master Aug 30, 2016
@RisingFog RisingFog deleted the frame_advance branch August 30, 2016 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants