-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Frame Advance #8939
Add Frame Advance #8939
Conversation
if (frameStep_) | ||
{ | ||
frameStep_ = false; | ||
Core_EnableStepping(true); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, in EmuScreen
this might actually be a better place:
This will be once per displayed frame though, so importantly:
- If frameskip is enabled, it will not happen for skipped frames.
- If the game runs at 30fps, it will be at 30fps.
-[Unknown]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couldn't get it to update the screen properly while frame advancing.
Looks okay to me, just needs static. -[Unknown] |
Functionality and idea seem fine to me, but is it possible to get out of the frame stepping state on Android, where you can't access the Run command from a menu? If it's problematic on Android and other non-Win32 platforms, one option would be to only enable this feature on Windows until it can be solved. |
I've (hopefully) removed the option from mobile devices. |
There are still some platforms that are not mobile but don't have a menu, like the SDL Mac build, but meh. Thanks! |
This adds preliminary support for Frame Advance within PPSSPP. For some reason, there's a lot of extra changes in regards to whitespaces, not sure why.