-
Notifications
You must be signed in to change notification settings - Fork 730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[geo] add graticule #111
[geo] add graticule #111
Conversation
<Graticule lines={g => path(g)} {...graticuleLines} />} | ||
{graticuleOutline && | ||
graticuleOutline.foreGround && | ||
<Graticule outline={g => path(g)} {...graticuleOutline} />} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any idea to resolve this repeating code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want to change "foreGround" to "foreground"...
awesome, thanks @nschnierer! I'll put aside some time to review this more throughly in the next couple of days. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I'm going to play around with a bit before publishing and see if there's a happy way for resolving the repeating code. I'll also do the foreGround
=> foreground
change.
👍
looks like a test failed cause of typo. I'll update that after the merge. Expected value to be (using ===):
"vx-mercator vx-new"
Received:
"vx-geo-mercator" |
Great. Need to add tests for the next pull request. |
Implemented graticule for projection's.
Draw graticule:
Graticule lines in foreground of the map and outline:
Any other ideas to implement graticule. I think graticule as prop is fine because a graticule without a projection doesn't make sense.