-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add explicit include
to Cargo.toml
#69
Comments
The other stuff is needed for running |
I don't think you need to supply what's needed for |
I've generally tried to keep test stuff inside the crate, although I don't have any automated processes in place to check it. The reason why I have done that is because it seems like a generally good idea to make it possible to download a crate from crates.io and be able to run its test suite with whatever it is you downloaded. Particularly for tooling like crater. But @XAMPPRocky is right in that it's unlikely you'll hear any complaints. Otherwise, I don't think there is any firm established practice here. |
That doesn't affect this crate though right? The tests that |
Ah gotya. I didn't look too closely at the specific setup here. :-) |
I noticed that
encoding-rs
is the largest download in my crate graph at 1.4MB. While relatively it's not a lot, this could reduced significantly, by just adding ainclude
to theCargo.toml
and only including what is needed to build the crate with the licence and copyright. I'm not too familiar with the project structure so there might more needed but this seems like everything.The text was updated successfully, but these errors were encountered: