Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: add temperature support patch? #49

Closed
cristianocang opened this issue Aug 31, 2020 · 7 comments
Closed

Feature request: add temperature support patch? #49

cristianocang opened this issue Aug 31, 2020 · 7 comments

Comments

@cristianocang
Copy link

cristianocang commented Aug 31, 2020

Hi

It is possible to add the temperature patch, so the AUR package htop-temperature won't be needed anymore?

The patch itself is available here.

Thank you very much!

@natoscott natoscott changed the title Add temperature suport patch? Feature request: add temperature support patch? Sep 3, 2020
@natoscott
Copy link
Member

@cristianocang makes sense to me (htop already reports battery status). Could you request the original code author(s) open a pull request on this git repo? Thanks!

@cristianocang
Copy link
Author

Just did it! I hope the author of the patches answers soon.

@DX37
Copy link

DX37 commented Sep 4, 2020

Hey there, DragonX256 from AUR here. I'll create pull request now.

@DX37
Copy link

DX37 commented Sep 17, 2020

So, should #93 resolve this issue, or #111?

@DX37
Copy link

DX37 commented Nov 17, 2020

So issue closed with no discussion which implementation should be included, but variant, created by one of the main developers is preferred? Cool, cool...
@natoscott, I don't understand.

@DX37
Copy link

DX37 commented Nov 17, 2020

Okay, just saw mention in commit.
You would at least say that you chose a different implementation, not just quiet merge/close.

@fasterit
Copy link
Member

@DX37 I tried to express exactly that by merging one and closing the other.
I explicitly thanked you because your implementation and inspiration made somebody else provide a superior implementation. That should make you proud, it is the way open source is meant to work. And I tried to express the core team's gratitude for your leadership in this. I'm sorry you did not receive the message as intended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants