Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Callback should get the same parameters as the "error" event handler #555

Closed
indexzero opened this issue Jan 19, 2014 · 0 comments
Closed

Callback should get the same parameters as the "error" event handler #555

indexzero opened this issue Jan 19, 2014 · 0 comments

Comments

@indexzero
Copy link
Contributor

See: https://github.com/nodejitsu/node-http-proxy/blob/master/lib/http-proxy/passes/web-incoming.js#L110-L114

Otherwise it is impossible to send the correct responses back to the res or make decisions based of the req on errors.
@yawnt yawnt closed this as completed in e936d18 Jan 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@indexzero