Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x-forwarded-proto incorrectly set to 'http' on node 0.12.0 #772

Closed
jphaas opened this issue Feb 11, 2015 · 3 comments · Fixed by #789
Closed

x-forwarded-proto incorrectly set to 'http' on node 0.12.0 #772

jphaas opened this issue Feb 11, 2015 · 3 comments · Fixed by #789

Comments

@jphaas
Copy link

jphaas commented Feb 11, 2015

I upgraded node to 0.12.0 and it looks like the https detection logic isn't working any more.

It looks like the issue is on line 70 of /lib/http-proxy/passes/web-incoming.js: req.connection.pair is evaluating to undefined even though it's an https connection.

I'm creating a server like so:

https_server = https.createServer my_https_options, (req, res) ->
    proxy.web req, res, {
        xfwd: true
        target: {host: 'localhost', port: configuration.port}
    }

https_server.listen configuration.ssl_port
@jcrugzz
Copy link
Contributor

jcrugzz commented Feb 11, 2015

@jphaas Ill see what the right thing to do is now and start testing on 0.12 so we can see that status. Thanks for the report

@feross
Copy link
Contributor

feross commented Mar 11, 2015

This is confirmed on iojs 1.5.1 as well.

@feross
Copy link
Contributor

feross commented Mar 11, 2015

Just sent a PR to fix this issue: #789

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants