Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recv_trailers should return a concrete type #96

Closed
yoshuawuyts opened this issue Apr 13, 2020 · 1 comment · Fixed by #103
Closed

recv_trailers should return a concrete type #96

yoshuawuyts opened this issue Apr 13, 2020 · 1 comment · Fixed by #103
Milestone

Comments

@yoshuawuyts
Copy link
Member

Request::recv_trailers and Response::recv_trailers should return non-clone channels, matching their Sender counterparts. I'm currently integrating this, and because we have an anonymous future calling it from a poll context means we need to box it, which isn't great.

@yoshuawuyts yoshuawuyts added this to the breaking milestone Apr 13, 2020
@yoshuawuyts
Copy link
Member Author

Also there's no decent way to handle the errors sent at that point, unless we only allow for io errors to be passed along. I think it's better to acknowledge operations regarding trailers should never fail and go from there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant