Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken file name/line number in logs #724

Open
kamilkloch opened this issue Aug 4, 2022 · 2 comments
Open

Broken file name/line number in logs #724

kamilkloch opened this issue Aug 4, 2022 · 2 comments

Comments

@kamilkloch
Copy link

Sample log line:

[2022-08-04 11:50:05,273] INFO  [io-compute-0] o.h.b.s.Http1ServerStage$$anon$1:271 - HTTP body not read to completion. Dropping connection.

Log entry claims this is Http1ServerStage from http4s-blaze-server.
Actual logging takes place in Http1Stage:271 from http4s-blaze-core.

Problem is that logger instance gets passed around between components - either by accessing parent class' logger (org.http4s.blaze.pipeline.Stage defines logger that is protected and used in derived classes), or by explicit passing around logger reference (org.http4s.blaze.server.Http1ServerParser).

This is an antipattern which renders the logs much less user-friendly.

@armanbilge
Copy link
Member

Thanks for the report! I guess this is a blaze-specific issue, right? I guess it should be transferred then, I think @danicheg can do that.

https://github.com/http4s/blaze

@kamilkloch
Copy link
Author

kamilkloch commented Aug 4, 2022

Should I open this issue in blaze?
Update: Never mind, I guess issue can be directly transferred.

@danicheg danicheg transferred this issue from http4s/http4s Aug 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants