-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Broken file name/line number in logs #724
Labels
Comments
Thanks for the report! I guess this is a blaze-specific issue, right? I guess it should be transferred then, I think @danicheg can do that. |
Should I open this issue in blaze? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Sample log line:
Log entry claims this is
Http1ServerStage
fromhttp4s-blaze-server
.Actual logging takes place in
Http1Stage:271
fromhttp4s-blaze-core
.Problem is that
logger
instance gets passed around between components - either by accessing parent class' logger (org.http4s.blaze.pipeline.Stage
defines logger that is protected and used in derived classes), or by explicit passing around logger reference (org.http4s.blaze.server.Http1ServerParser
).This is an antipattern which renders the logs much less user-friendly.
The text was updated successfully, but these errors were encountered: