Decode headers using utf-8 only if they are not str #1020
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
httpie showed a strange behavior whenever I was using sessions with files uploads using multipart forms, returning the following error during execution:
So, I tested with debug:
After some investigation, I noticed the error was generated from the usage of the header returned from get_multipart_data_and_content_type containing the
Content-Type
header for the multipart form, which returns an encoder and the header as a string, at collect_messages as a byte in update_headers using the decode method to generate a string from it.To solve this issue I added a new test and then modified the
update_headers
function to not decode the header if it is already a string.