-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix time elapsed #1277
Fix time elapsed #1277
Conversation
jkbrzt
commented
Jan 23, 2022
- show the actual time elapsed instead of time-to-parse-headers
- add docs for response meta
Codecov Report
@@ Coverage Diff @@
## master #1277 +/- ##
==========================================
- Coverage 97.28% 96.57% -0.72%
==========================================
Files 67 85 +18
Lines 4235 5952 +1717
==========================================
+ Hits 4120 5748 +1628
- Misses 115 204 +89
Continue to review full report at Codecov.
|
…eaders_parsed_at`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are faster than me 😄 (I was planning this on monday). The conditional body download seems a bit weird, considering how output options can change the total elapsed time but I guess there is no easy solution on that front. Maybe we might consider adding a warning in the future (Elapsed Time: 1.2042824 seconds (excluding time spent on the response body)
) or using different keys but since it is documented I guess it is not a big deal.
Yeah, the conditional body download, which is otherwise a good thing, makes the metrics less robust. The notice might be a good idea for a future iteration. |