Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building Issue Ubuntu 22.04 (improvement) #48

Open
neil-yoga-crypto opened this issue Sep 26, 2022 · 2 comments
Open

Building Issue Ubuntu 22.04 (improvement) #48

neil-yoga-crypto opened this issue Sep 26, 2022 · 2 comments

Comments

@neil-yoga-crypto
Copy link

Thank you for making this tool!

Just a small thing, after downloading all the files, I received this message on my Ubuntu 22.04 machine:

"⨯ to build rpm, executable rpmbuild is required, please install: sudo apt-get install rpm"

It would be nice to check the dependencies before downloading everything.

@pimterry
Copy link
Member

Oooh, good suggestion! By 'downloading all the files', you mean the server download step?

If you want to open a PR to add a check step before that, that would be very welcome, sure! It would be best to add that as another npm script here, maybe check-dependencies or similar, and then running that step as part of the existing build:electron step. That step can just run a TS script like server:setup does, and implementing whatever checks are required there.

I would suggest taking a look at the code for Electron Builder to find exactly how they do this rpmbuild check (and what else they check for) just to make sure the logic is the same.

@neil-yoga-crypto
Copy link
Author

Thanks. It's after I run npm run build, which cause many things such as Electron to download.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants