Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No node-datachannel prebuilds are available for M1 Mac, so manual builds are required to install #2

Open
lichstam opened this issue Jul 18, 2022 · 5 comments

Comments

@lichstam
Copy link

doesn't seem to support higher version of node. could this perhaps be resolved by upgrading node-datachannel?

@pimterry
Copy link
Member

Hi @lichstam. In theory, the library should work perfectly in Node 16. I've used it elsewhere downstream with v16 myself, and all the CI tests are automatically run against the latest release of Node 16 too.

Can you share more details about the issue you're seeing?

@lichstam
Copy link
Author

i can't even install it

Screenshot 2022-07-18 at 10 50 41

Screenshot 2022-07-18 at 10 47 39

@pimterry
Copy link
Member

Ah, ok. What should happen here is that the latest binaries for your specific OS & architecture are automatically pulled from GitHub releases during the install, so no build happens. For some reason that isn't working, so it's trying to build from scratch, and then you don't have the complete environment set up for that.

It might be possible to work around this by setting up a full build environment with OpenSSL etc, but it suggests that there's a missing release build in the published prebuilt binaries (here), or a bug in the code that pulls them, and it'd be better to get that fixed.

Can you run uname -a in your terminal, and post the output here? That should tell us which binary you're looking for.

@pimterry
Copy link
Member

Ok, I think it's pretty likely that this is because you're using a new M1 Mac, and node-datachannel only publishes binaries for x64 (because GitHub doesn't yet support CI builds with M1 Macs). Does that sound plausible?

Given that, I think I have a solution, but we'll need to fix this upstream in node-datachannel, and we'll need the help of somebody (maybe you?) with an M1 Mac to test the resulting binaries so we can be sure the fix actually works. Are you open to helping with that? I've added some detail in node-datachannel: murat-dogan/node-datachannel#120

@lichstam
Copy link
Author

@pimterry yes, sure!

@pimterry pimterry changed the title Node >=16 No node-datachannel prebuilds are available for M1 Mac, so manual builds are required to install Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants