Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timezone support #56

Closed
me1299 opened this issue May 15, 2019 · 8 comments
Closed

Timezone support #56

me1299 opened this issue May 15, 2019 · 8 comments

Comments

@me1299
Copy link
Contributor

me1299 commented May 15, 2019

It would be nice to set the correct timezone for the docker container. Now my log files are not in sync with the actual time making it harder to debug.

Time zone data package tzdata could be included in the container.

@huan
Copy link
Owner

huan commented May 18, 2019

Yes, we should.

And actually, we have already support it by setting the TZ environment by the docket -e to change the timezone inside the container.

However, we have not document it in the README yet.

Would you like to add a section to the README for the timezone support? A PR will be very welcome.

@me1299
Copy link
Contributor Author

me1299 commented Jun 6, 2019

Hi Huan,

This is actually not working for me. I've set the timezone in my docker compose file.
Within the docker container:

echo $TZ
Europe/Amsterdam

So the TZ variable is available, but after requesting the time:

date
Thu Jun 6 10:11:12 UTC 2019

It's 2 hours of.
Amsterdam is UTC+1 (+2 with daylight savings)

@huan
Copy link
Owner

huan commented Jun 6, 2019

@me1299 Yes, you are right.

I had just tested in the docker container and it not worked.

I believe we should add tzdata to the docker image as you suggested.

Would you like to send a PR to fix this problem? Thank you very much.

@me1299
Copy link
Contributor Author

me1299 commented Jun 7, 2019

@huan Consider it done ;)

@huan
Copy link
Owner

huan commented Jun 8, 2019

The latest docker image had been published, please let me know if it works or not.

Thanks for your contribution!

@me1299
Copy link
Contributor Author

me1299 commented Jun 8, 2019

Hi Huan,

It's working!

@huan
Copy link
Owner

huan commented Jun 9, 2019

Glad to hear that, Cheers! 🍻

@huan
Copy link
Owner

huan commented Jun 9, 2019

@me1299 One more thing:

Would you like to add one-line documentation of how to set the timezone with TZ environment variable in README? Because that would help other developers a lot when they need this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants