Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix toJSON() return type: should be string instead of object #151

Open
huan opened this issue Aug 14, 2018 · 0 comments
Open

Fix toJSON() return type: should be string instead of object #151

huan opened this issue Aug 14, 2018 · 0 comments
Labels

Comments

@huan
Copy link
Owner

huan commented Aug 14, 2018

This function should return a type string instead of object

https://github.com/zixia/node-facenet/blob/b1e4f4b62383699d4c2e670abfe00613e47d0828/src/face.ts#L331

According to https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/JSON/stringify:

The JSON.stringify() method converts a JavaScript value to a JSON string
JSON.stringify() converts a value to JSON notation representing it: If the value has a toJSON() method, it's responsible to define what data will be serialized.

@huan huan added the bug label Aug 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant