Always initalize DateTime in UTC. Fixes matomo-org#52.

Author: huan086

Piwik.Tracker.Samples/PiwikTrackerSamples.cs

@@ -131,7 +131,7 @@ static private void RecordSimplePageViewWithCustomProperties()
             piwikTracker.SetIp("192.168.52.64");
             piwikTracker.SetVisitorId("33c31B01394bdc65");
 
-            piwikTracker.SetForceVisitDateTime(new DateTime(2011, 10, 23, 10, 20, 50));
+            piwikTracker.SetForceVisitDateTime(new DateTime(2011, 10, 23, 10, 20, 50, DateTimeKind.Utc));
 
             piwikTracker.SetResolution(1600, 1400);
 
@@ -143,7 +143,7 @@ static private void RecordSimplePageViewWithCustomProperties()
             piwikTracker.SetPlugins(browserPluginsToSet);
             piwikTracker.SetBrowserHasCookies(true);
 
-            piwikTracker.SetLocalTime(new DateTime(2000, 1, 1, 9, 10, 25));
+            piwikTracker.SetLocalTime(new DateTime(2000, 1, 1, 9, 10, 25, DateTimeKind.Utc));
 
             piwikTracker.SetUrl("http://piwik-1.5/supernova");
             piwikTracker.SetUrlReferrer("http://supernovadirectory.org");
@@ -201,7 +201,7 @@ static private void GoalConversionWithAttributionInfo()
 
             attributionInfo.CampaignName = "CAMPAIGN NAME";
             attributionInfo.CampaignKeyword = "CAMPAIGN KEYWORD";
-            attributionInfo.ReferrerTimestamp = new DateTime(2011, 04, 08, 23, 48, 24);
+            attributionInfo.ReferrerTimestamp = new DateTime(2011, 04, 08, 23, 48, 24, DateTimeKind.Utc);
             attributionInfo.ReferrerUrl = "http://www.example.org/test/really?q=yes";
 
             piwikTracker.SetAttributionInfo(attributionInfo);

Piwik.Tracker.Tests/PiwikTrackerTests.cs

@@ -187,7 +187,7 @@ public void SetAttributionInfo_WhenReferrerTimestampSpecified_IsAddedToRequest(s
                 _sut.SetAttributionInfo(new AttributionInfo { ReferrerTimestamp = referrerTimestamp });
                 // Assert
                 var actual = _sut.GetRequest(SiteId);
-                Assert.That(actual, Does.Contain("&_refts=" + referrerTimestamp.ToUnixTimeSeconds().ToString().Substring(0, 6)));
+                Assert.That(actual, Does.Contain("&_refts=" + referrerTimestamp.ToUnixTimeSeconds()));
             }
         }
 

Piwik.Tracker.Web.Samples/samples/ServerSideGoalTracking.aspx

@@ -18,7 +18,7 @@ This page tracks a goal conversion with the Server Side tracking API and display
 
     attributionInfo.CampaignName = "CAMPAIGN NAME";
     attributionInfo.CampaignKeyword = "CAMPAIGN KEYWORD";
-    attributionInfo.ReferrerTimestamp = new DateTime(2011, 04, 08, 23, 48, 24);
+    attributionInfo.ReferrerTimestamp = new DateTime(2011, 04, 08, 23, 48, 24, DateTimeKind.Utc);
     attributionInfo.ReferrerUrl = "http://www.example.org/test/really?q=yes";
 
     piwikTracker.SetAttributionInfo(attributionInfo);

Piwik.Tracker/AttributionInfo.cs

@@ -38,7 +38,7 @@ public string[] ToArray()
             var infos = new string[4];
             infos[0] = CampaignName;
             infos[1] = CampaignKeyword;
-            infos[2] = (ReferrerTimestamp - new DateTime(1970, 1, 1)).TotalSeconds.ToString(CultureInfo.InvariantCulture);
+            infos[2] = (ReferrerTimestamp - new DateTime(1970, 1, 1, 0, 0, 0, DateTimeKind.Utc)).TotalSeconds.ToString(CultureInfo.InvariantCulture);
             infos[3] = ReferrerUrl;
             return infos;
         }

Piwik.Tracker/PiwikTracker.cs

@@ -182,7 +182,7 @@ public class PiwikTracker
         private bool _configCookiesDisabled;
         private string _configCookiePath = DefaultCookiePath;
         private string _configCookieDomain = "";
-        private readonly long _currentTs = (long)(DateTime.Now - new DateTime(1970, 1, 1)).TotalSeconds;
+        private readonly long _currentTs = (long)(DateTime.UtcNow - new DateTime(1970, 1, 1, 0, 0, 0, DateTimeKind.Utc)).TotalSeconds;
         private long _createTs;
         private long? _visitCount = 0;
         private long? _currentVisitTs;
@@ -1344,7 +1344,7 @@ public AttributionInfo GetAttributionInfo()
 
             if (arraySize > 2 && !string.IsNullOrEmpty(cookieDecoded[2]))
             {
-                attributionInfo.ReferrerTimestamp = new DateTime(1970, 1, 1, 0, 0, 0).AddSeconds(Convert.ToInt32(cookieDecoded[2]));
+                attributionInfo.ReferrerTimestamp = new DateTime(1970, 1, 1, 0, 0, 0, DateTimeKind.Utc).AddSeconds(Convert.ToInt32(cookieDecoded[2]));
             }
 
             if (arraySize > 3 && !string.IsNullOrEmpty(cookieDecoded[3]))
@@ -1749,7 +1749,7 @@ private string FormatDateValue(DateTimeOffset date)
 
         private string FormatTimestamp(DateTimeOffset date)
         {
-            DateTime origin = new DateTime(1970, 1, 1, 0, 0, 0, 0);
+            DateTime origin = new DateTime(1970, 1, 1, 0, 0, 0, 0, DateTimeKind.Utc);
             TimeSpan diff = date - origin;
             double seconds = Convert.ToInt32(diff.TotalSeconds);
             return seconds.ToString(CultureInfo.InvariantCulture);