Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add non-binarized casual matrix #126

Open
YUYING07 opened this issue Aug 16, 2023 · 2 comments
Open

add non-binarized casual matrix #126

YUYING07 opened this issue Aug 16, 2023 · 2 comments

Comments

@YUYING07
Copy link

#121
CORL, DAG-GNN, and other methods only return and thresh comparison of 0-1 matrix, which CORL thresh is the algorithm comes with 0.3 can not be changed, but a lot of datasets with 0.3 is not accurate, can be in the original method are added to return the original value of the casual_matrix function?

@shaido987
Copy link
Collaborator

Hello,

that CORL has a fixed 0.3 threshold is something that must have been overlooked. It should be quick and easy to add an additional input parameter with the desired value. We will correct this in the coming days.

For adding the non-binary matrix, we would be happy to merge a PR that adds it to the BaseLearner and all the algorithms. As this changes the possible outputs of an algorithm it would be confusing if it's only supported by a subset of the algorithms (hence adding it to all algorithms would be better).

@YUYING07
Copy link
Author

YUYING07 commented Aug 17, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants