Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add serialization JSON output #1035

Open
bitwiseman opened this issue Feb 11, 2021 · 2 comments
Open

Add serialization JSON output #1035

bitwiseman opened this issue Feb 11, 2021 · 2 comments

Comments

@bitwiseman
Copy link
Member

Several users have filed issues around serializing objects to JSON: #1034, #971.

Consider adding a toJSON() method to objects, readRawJSON() method to GitHub, or documenting a supported way to do this using the existing ObjectMapper returning methods.

@l3ender
Copy link
Contributor

l3ender commented Mar 15, 2024

I arrived here with a similar need/ask as described in #235. We want to leverage this library for its handling of the GitHub API complexities (authentication, paging, rate limiting, etc), but are interested in getting the raw JSON data--as returned from the API--in order to save/process it separately, without needing to worry about regularly checking/updating library in case of new API additions.

I know this and related issues are a few years old, but any thoughts/ideas of how to accomplish it?

FWIW, in other parts of our application(s), we do use (and love) this library for its OO approach and simplification of the API. Thank you!

@bitwiseman
Copy link
Member Author

@l3ender
This issue is about serializing GH* instances to JSON and creating usable GH* instances from raw JSON provided by the user.
GH*.toJSON() output would be limited to the fields on the class, not the same as the raw JSON returned from GitHub.

I think what you're asking for is closer to #513 (and adding a fetchJSONString()). Maybe also adjacent to #1232.

Please open a new issue and include details about your scenarios in there - examples of what you want to do and what advantages the raw JSON has in that scenario(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants