Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggested enhancement: GHPerson#getAllRepositories() #110

Closed
alexrothenberg opened this issue Jul 17, 2014 · 3 comments
Closed

Suggested enhancement: GHPerson#getAllRepositories() #110

alexrothenberg opened this issue Jul 17, 2014 · 3 comments

Comments

@alexrothenberg
Copy link

Currently GHPerson#getRepositories() will only get the first 30 repositories. It would be useful (to me) to have a getAllRepositories that returns a map of all my repositories, if there are a lot it would follow pagination links making several github api requests.

Would you be open to this enhancement? If so I'll work on a pull request.

Thanks

@suryagaddipati
Copy link
Collaborator

@alexrothenberg seems like new github api version changed this to have pagination. There is another pr for Pagination (#107 ), not sure if thats helpful

@alexrothenberg
Copy link
Author

Yes that pull looks great but as far as i can tell getRepositories doesn't call the changed code. listRepositories calls Requestor#asIterator where it looks like it would have to change to call Requestor#to. Or am I missing where this new code would be called?

@kohsuke
Copy link
Collaborator

kohsuke commented Feb 15, 2015

This works as expected as of 1.61

@kohsuke kohsuke closed this as completed Feb 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants