Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GHTeam.getMembers() response does not include all users if user count >30 #145

Closed
if6was9 opened this issue Dec 28, 2014 · 1 comment
Closed

Comments

@if6was9
Copy link

if6was9 commented Dec 28, 2014

I have not gotten to the bottom of why this is happening, but getMembers() returns at most 30 members, even if the team has more.

I have a strong suspicion that the API is returning paged results but the response processing is not fetching the pages.

Will submit a PR if I can get it fixed.

@if6was9
Copy link
Author

if6was9 commented Dec 28, 2014

Confirmed to be a paging issue. Here is the relevant code:

https://github.com/kohsuke/github-api/blob/master/src/main/java/org/kohsuke/github/GHTeam.java#L54-L56

Since the declaration returns a Set, returning a PagedIterable isn't an option.

I think an eager fetch to retrieve all pages and populate the Set makes the most sense.

Note: I am positive that this API was not paged previously. Sometime in the last 6-12 months, GitHub has changed the implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant