Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GHEventPayload should not contain repository as a root level property #1771

Open
Haarolean opened this issue Dec 16, 2023 · 1 comment
Open

GHEventPayload should not contain repository as a root level property #1771

Haarolean opened this issue Dec 16, 2023 · 1 comment
Labels
breaking change bug

Comments

@Haarolean
Copy link
Contributor

Probly a candidate for a breaking change for v2:
GHEventPayload probably should not contain repository as a root level property as it might not be present in every webhook payload. An example would be installation event, which is evident from org/kohsuke/github/GHEventPayloadTest/installation.json contents.
@Haarolean
Copy link
Contributor Author

The same applies to installation field, one can be missing from some payloads, e.g. sponsorship.
Github docs still contains these fields, and the only "warning" is this part of the description: "Webhook payloads contain the repository property when the event occurs from activity in a repository.".

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Haarolean @bitwiseman