Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<null> fields yeld NPE on getX operations. #372

Closed
baranowb opened this issue Aug 22, 2017 · 2 comments
Closed

<null> fields yeld NPE on getX operations. #372

baranowb opened this issue Aug 22, 2017 · 2 comments

Comments

@baranowb
Copy link

GHPullRequest@645aa696[base=org.kohsuke.github.GHCommitPointer@7ce026d3,head=org.kohsuke.github.GHCommitPointer@7ce69770,additions=1,merged=false,mergeable=,deletions=1,assignee=,state=open,number=1903,comments=2,labels=,title=XXXXX,milestone=,url=PR_URL,id=122473208]

Will throw NPE on .getMergeable()

@baranowb
Copy link
Author

https://developer.github.com/v3/pulls "The value of the mergeable attribute can be true, false, or null. If the value is null, this means that the mergeability hasn't been computed yet, and a background job was started to compute it. Give the job a few moments to complete, and then submit the request again. When the job is complete, the response will include a non-null value for the mergeable attribute."

This should be reflected in field. Worse case scenario with Boolean, so null can be one of potential values or with proper enum YES,NO, NOT_DEFINED( or something similar)

@kohsuke
Copy link
Collaborator

kohsuke commented Sep 9, 2017

Without stack trace, I'm afraid I cannot fix this.

@kohsuke kohsuke closed this as completed Sep 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants