Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

createTeam with permission field deprecated in API but library still uses the field #617

Closed
asthinasthi opened this issue Nov 18, 2019 · 1 comment
Closed

createTeam with permission field deprecated in API but library still uses the field #617

asthinasthi opened this issue Nov 18, 2019 · 1 comment
Labels
bug

Comments

@asthinasthi
Copy link

asthinasthi commented Nov 18, 2019 •
edited
Loading

In https://developer.github.com/v3/teams/#create-team

permission field is deprecated. But the library still expects a permission field. https://github.com/github-api/github-api/blob/da11702f6815f658014f33ce724f0cd2e4501081/src/main/java/org/kohsuke/github/GHOrganization.java#L387

Is it on the roadmap to align the library with the deprecation?

I have created a PR: #619 to refactor this.
@asthinasthi asthinasthi changed the title createTeam with permission deprecated in API but library still uses the field createTeam with permission field deprecated in API but library still uses the field Nov 18, 2019
@bitwiseman bitwiseman added the bug label Nov 19, 2019
@bitwiseman
Copy link
Member

bitwiseman commented Nov 20, 2019 •
edited
Loading

Closed by #619 . Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bitwiseman @asthinasthi