Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Staging review: Tweak HuBMAP nav menu to be more responsive #825

Closed
LibbyUX opened this issue Nov 19, 2024 · 1 comment
Closed

Staging review: Tweak HuBMAP nav menu to be more responsive #825

LibbyUX opened this issue Nov 19, 2024 · 1 comment
Assignees
@edlu77
Labels
app: apps.humanatlas.io apps.humanatlas.io app: cde-ui Cell Distance Explorer app: design system storybook HRA Design System Storybook for global consistency across HRA products bug 🐛 Something isn't working high priority Priority task for product team ⚙️ hra-ds: update ✨ An update to an already existing component in the HRA Design System Storybook update: responsive 📲 Updates to responsiveness in an application.
Milestone
Develop: CDE-UI (...

Comments

@LibbyUX
Copy link
Contributor

LibbyUX commented Nov 19, 2024 •
edited
Loading

Katy reviews the CDE staging:

image

image

Resources

Please let me know how I can assist!

Current implementation design behavior

  • The menu itself needs to fill the entire width of the screen up to the max width of 580px and the text in container should use a fill width as specified.
  • The minimum width for this component in the spec is currently 320px, the smallest width for phones on the market right now. I believe Katy's is around 430px.

F12612EB-52C2-444C-BC5F-F8C1F1E4FE73
@LibbyUX LibbyUX added bug 🐛 Something isn't working app: cde-ui Cell Distance Explorer app: design system storybook HRA Design System Storybook for global consistency across HRA products update: cosmetics 💄 Cosmetic UI updates app: apps.humanatlas.io apps.humanatlas.io ⚙️ hra-ds: update ✨ An update to an already existing component in the HRA Design System Storybook labels Nov 19, 2024
@LibbyUX LibbyUX added this to the Develop: CDE-UI milestone Nov 19, 2024
@LibbyUX LibbyUX added the high priority Priority task for product team label Nov 19, 2024
@LibbyUX LibbyUX changed the title Tweak menu to be more responsive Tweak HuBMAP nav menu to be more responsive Nov 19, 2024
@LibbyUX LibbyUX added update: responsive 📲 Updates to responsiveness in an application. and removed update: cosmetics 💄 Cosmetic UI updates labels Nov 19, 2024
@edlu77 edlu77 mentioned this issue Nov 19, 2024
Merged
@LibbyUX LibbyUX changed the title Tweak HuBMAP nav menu to be more responsive Staging review: Tweak HuBMAP nav menu to be more responsive Nov 19, 2024
@LibbyUX
Copy link
Contributor Author

LibbyUX commented Nov 19, 2024

@edlu77 & @axdanbol, thank you for squaring this away so quickly!

@LibbyUX LibbyUX closed this as completed Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@edlu77 edlu77

Labels
app: apps.humanatlas.io apps.humanatlas.io app: cde-ui Cell Distance Explorer app: design system storybook HRA Design System Storybook for global consistency across HRA products bug 🐛 Something isn't working high priority Priority task for product team ⚙️ hra-ds: update ✨ An update to an already existing component in the HRA Design System Storybook update: responsive 📲 Updates to responsiveness in an application.
Projects
None yet
Milestone
Develop: CDE-UI (2.8 Cell Distance Ex...
Development

No branches or pull requests
2 participants
@edlu77 @LibbyUX