You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Most of these values take arguments, but one, HUBOT_HTTPD, is a boolean. It defaults to true and, when set to false, the Express HTTP server is disabled. However, the logic for setting it is buggy; the variable is assigned the same way as with the others that take arguments, so it effectively assigns enableHttpd to a string or true. This has two problems:
All JavaScript strings except an empty string are truthy, and it's unintuitive that the only meaningful value is HUBOT_HTTPD=.
[falsy value] || true evaluates to true, so regardless of what the user does the result is still the same.
The text was updated successfully, but these errors were encountered:
bin/hubot.js
allows specifying several options via environment variables and commandline switches: https://github.com/hubotio/hubot/blob/master/bin/hubot.js#L23-L29Most of these values take arguments, but one,
HUBOT_HTTPD
, is a boolean. It defaults totrue
and, when set tofalse
, the Express HTTP server is disabled. However, the logic for setting it is buggy; the variable is assigned the same way as with the others that take arguments, so it effectively assignsenableHttpd
to a string ortrue
. This has two problems:HUBOT_HTTPD=
.[falsy value] || true
evaluates totrue
, so regardless of what the user does the result is still the same.The text was updated successfully, but these errors were encountered: