Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax restrictions on MAP_* constant names #614

Open
GriffinRichards opened this issue Sep 17, 2024 · 0 comments
Open

Relax restrictions on MAP_* constant names #614

GriffinRichards opened this issue Sep 17, 2024 · 0 comments
Assignees
Labels
release target This should be resolved before the next release

Comments

@GriffinRichards
Copy link
Collaborator

Currently Porymap requires that for any map FooBar its ID is MAP_FOO_BAR. There's not much of a reason to require this, beyond the fact that we'd have to discover map IDs beforehand by opening every map.json file. We're already doing this in order to get MAPSEC and LAYOUT ids for the map list (and not caching the result!), so we may as well get all 3 of these constants on launch and relax the name restriction so that the only requirements are 1. it's unique, and 2. it begins with the user-provided prefix (MAP_ by default).

@GriffinRichards GriffinRichards added the release target This should be resolved before the next release label Sep 17, 2024
@GriffinRichards GriffinRichards self-assigned this Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release target This should be resolved before the next release
Projects
None yet
Development

No branches or pull requests

1 participant