Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UPDATE] Dummy Agent Library: Missing Thought step before Final Answer #296

Open
A-rqb opened this issue Mar 6, 2025 · 1 comment
Open
Labels
documentation Improvements or additions to documentation

Comments

@A-rqb
Copy link

A-rqb commented Mar 6, 2025

At the very end of the Dummy Agent Library page, we can see the Final Answer being printed correctly.
One thing that is most likely missing, is the "Thought: I now know the final answer" that the system prompt explicitly asked to generate before the "Final Answer".

I hope this is clear. If not please let me know, I will be more than happy to add details and screenshots.

@A-rqb A-rqb added the documentation Improvements or additions to documentation label Mar 6, 2025
@mehmoodosman
Copy link

mehmoodosman commented Mar 8, 2025

Yes and another thing.

I believe this code should be added in the notebook to ensure best practice for HF_TOKEN as secret key instead of hardcoding the secret in the colab file.

It's a relatively minor thing but could potentially prevent someone's HF_TOKEN secret key from being made vulnerable unintentionally.

from google.colab import userdata

os.environ["HF_TOKEN"] = userdata.get('HF_TOKEN')

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants