Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PatchTSMixer tutorial broken. ForecastDFDataset API change #2120

Open
emanuelshalev opened this issue Jun 1, 2024 · 6 comments
Open

PatchTSMixer tutorial broken. ForecastDFDataset API change #2120

emanuelshalev opened this issue Jun 1, 2024 · 6 comments

Comments

@emanuelshalev
Copy link

in the tutorial this is how ForecastDFDataset is used:

train_dataset = ForecastDFDataset(
time_series_processor.preprocess(train_data),
id_columns=id_columns,
timestamp_column="date",
input_columns=forecast_columns,
output_columns=forecast_columns,

context_length=context_length,
prediction_length=forecast_horizon,
)

but input_columns and output_columns are no longer valid parameters. What is the correct usage?

@vijaye12
Copy link

vijaye12 commented Jun 4, 2024

We have deprecated ForecastDataset API and using TSP for dataset generation.

you can check the example here https://colab.research.google.com/github/IBM/tsfm/blob/tutorial/notebooks/tutorial/ttm_tutorial.ipynb

Also, you can also try using TTM (which is an advanced version of PatchTSMixer). Here is the model card https://huggingface.co/ibm-granite/granite-timeseries-ttm-v1

@millen11
Copy link

I am trying to use the regular PatchTST model per this documentation :https://huggingface.co/blog/patchtst. I run into the same problems as the original issue and have tried the links provided as a solution, however that had more issues. Any insight on a fix?

@osanseviero
Copy link
Contributor

cc @kashif

@etpereira
Copy link

Same problem here...
Could anyone help?

@kashif
Copy link
Contributor

kashif commented Dec 10, 2024

thanks for the report @etpereira let me have a look again

@etpereira
Copy link

@kashif , I was just looking at this link https://github.com/ibm-granite/granite-tsfm/blob/main/notebooks/hfdemo/patch_tsmixer_getting_started.ipynb

And discover a mode of doing it work:

The correct arguments are:

tsp.preprocess(train_data),
id_columns=id_columns,
target_columns=forecast_columns,
context_length=context_length,
prediction_length=forecast_horizon,

Thank you, anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants