Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Tensor features #1279

Closed
2 tasks done
EricLBuehler opened this issue Nov 6, 2023 · 0 comments
Closed
2 tasks done

Missing Tensor features #1279

EricLBuehler opened this issue Nov 6, 2023 · 0 comments

Comments

@EricLBuehler
Copy link
Member

EricLBuehler commented Nov 6, 2023

Hello everybody,

I have identified several missing features from Tensor during my development of candle-vllm and candle-sampling. This issue serves to document these missing features:

  • Slice fill is missing
    It appears that there is no way to fill a slice of a tensor with values after creation. Possible solutions could include from a Copy type or a closure.
  • Iteration
    Tensor does not provide a method to iterate over a slice in the tensor.

I will update this issue if I find more apparently missing features.

Please correct me if these features are actually implemented. @LaurentMazare, do you think that these features could be added? It appears that Pytorch has these features implemented, so I think it is possible.

@EricLBuehler EricLBuehler closed this as not planned Won't fix, can't repro, duplicate, stale Nov 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant