Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push_to_hub in a pull request #5492

Closed
lhoestq opened this issue Feb 1, 2023 · 2 comments · Fixed by #6269 · May be fixed by #5528
Closed

Push_to_hub in a pull request #5492

lhoestq opened this issue Feb 1, 2023 · 2 comments · Fixed by #6269 · May be fixed by #5528
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@lhoestq
Copy link
Member

lhoestq commented Feb 1, 2023

Right now ds.push_to_hub() can push a dataset on main or on a new branch with branch=, but there is no way to open a pull request. Even passing branch=refs/pr/x doesn't seem to work: it tries to create a branch with that name

cc @nateraw

It should be possible to tweak the use of huggingface_hub in push_to_hub to make it open a PR or push to an existing PR

@lhoestq lhoestq added enhancement New feature or request good first issue Good for newcomers labels Feb 1, 2023
@nateraw nateraw self-assigned this Feb 1, 2023
@nateraw
Copy link
Contributor

nateraw commented Feb 1, 2023

Assigned to myself and will get to it in the next week, but if someone finds this issue annoying and wants to submit a PR before I do, just ping me here and I'll reassign :).

@AJDERS
Copy link

AJDERS commented Feb 13, 2023

I would like to be assigned to this issue, @nateraw . #self-assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
3 participants