Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LoRA for Dreambooth #1715

Closed
polavishnu4444 opened this issue Dec 15, 2022 · 13 comments
Closed

LoRA for Dreambooth #1715

polavishnu4444 opened this issue Dec 15, 2022 · 13 comments
Labels
stale Issues that haven't received updates

Comments

@polavishnu4444
Copy link

polavishnu4444 commented Dec 15, 2022

Hi,
Have come across LoRA for diffusion models.
It might be right for diffusers to collaborate and later get to one single diffusers SDK as Dreambooth is supported here as well in the current diffusers' library.
Interested to learn about your thoughts on this. 😃

Link: https://github.com/cloneofsimo/lora

@patrickvonplaten
Copy link
Contributor

patrickvonplaten commented Dec 19, 2022

Yes, very interested in adding this to diffusers. Would love to review a PR here. Note that it could be as simple to copy the correct training script from: https://huggingface.co/spaces/ysharma/Low-rank-Adaptation/tree/main into examples/lora

@patrickvonplaten
Copy link
Contributor

Also cc @pcuenca @williamberman @patil-suraj

@patil-suraj
Copy link
Contributor

LMK if anyone is interested in adding this, very happy to help :)

@Thomas-MMJ
Copy link

@cloneofsimo

@cloneofsimo
Copy link
Contributor

Ah sorry we've actually talked about this on the slack channel as well. Just finished final exam. I'll work on it today

@dhruvrnaik
Copy link
Contributor

Happy to help with it @cloneofsimo

@polavishnu4444
Copy link
Author

Interested as well if you can teach me 😃

@shirayu
Copy link
Contributor

shirayu commented Dec 30, 2022

Just for your information:

This repository includes another LoRA implementation, however I haven't tried.
https://github.com/kohya-ss/sd-scripts

Description in Japanese:
https://github.com/kohya-ss/sd-scripts/blob/main/train_network_README-ja.md

They stated that the main difference between the cloneofsimo's implementation at this time is more application of LoRA to MLP in Text Encoder, FFN in U-Net, and in/out projection in Transformer.

@patrickvonplaten
Copy link
Contributor

Starting working on it: #1884 -> should be ready end of week :-)

@cloneofsimo
Copy link
Contributor

I'm sorry for not updating this earlier. And thank you @patrickvonplaten ! I just checked this PR as well : #1639 this would make LoRA and Paint with words implementation much easier. (But would probably need refactor as well)

I've been trying to make LoRA better before implementing here, and with contributors, we've recently made 4 major progresses and improved fidelity considerably more. I'll try my best to implement them in the examples when I find time (or anyone can jump in)

@yasyf
Copy link
Contributor

yasyf commented Jan 3, 2023

@patil-suraj @patrickvonplaten I started working on the Flax version of this a while ago and got stuck. My work so far is in #1894!

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@github-actions github-actions bot added the stale Issues that haven't received updates label Jan 27, 2023
@patil-suraj
Copy link
Contributor

LoRA is now supported cf #1884

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Issues that haven't received updates
Projects
None yet
Development

No branches or pull requests

8 participants