Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ZipLora to enhance multi-lora inference #5925

Closed
AmericanPresidentJimmyCarter opened this issue Nov 24, 2023 · 4 comments
Closed

Add ZipLora to enhance multi-lora inference #5925

AmericanPresidentJimmyCarter opened this issue Nov 24, 2023 · 4 comments
Labels
stale Issues that haven't received updates

Comments

@AmericanPresidentJimmyCarter
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Refer to https://ziplora.github.io/

Describe the solution you'd like.
When multiple LoRAs are passed to the model, you should have the ability to use ziplora to merge them.

Additional context.
arxiv paper: https://arxiv.org/abs/2311.13600

@shauray8 shauray8 mentioned this issue Nov 25, 2023
4 tasks
@patrickvonplaten
Copy link
Contributor

@younesbelkada @pacman100 is this something you are looking into?

@sayakpaul
Copy link
Member

I think @pacman100 is already looking into it.

@Xynonners
Copy link

Xynonners commented Dec 7, 2023

wouldn't this make more sense in https://github.com/huggingface/peft though?

since it seems to be a training method / pseudo-new LoRA adapter (only for training).

Copy link

github-actions bot commented Jan 3, 2024

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@github-actions github-actions bot added the stale Issues that haven't received updates label Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Issues that haven't received updates
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants