Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking: migrate doc build artifacts from github to hf hub #316

Closed
12 of 15 tasks
mishig25 opened this issue Oct 24, 2022 · 6 comments
Closed
12 of 15 tasks

Tracking: migrate doc build artifacts from github to hf hub #316

mishig25 opened this issue Oct 24, 2022 · 6 comments

Comments

@mishig25
Copy link
Contributor

mishig25 commented Oct 24, 2022

Tracking: migrate doc build artifacts from github to hf hub

Why: because hf hub can handle large files & huggingface_hub python client library makes it easy to work with. (With github, we had to almost write python client from scratch using github graphql)

Dev Steps:

Migration Steps:

Resources:

internal slack discussion

@mishig25 mishig25 changed the title Tracking: migrate doc build artifcats from github to hf hub Tracking: migrate doc build artifacts from github to hf hub Oct 24, 2022
@coyotte508
Copy link
Member

coyotte508 commented Oct 24, 2022

If I understand it correctly, for now the repo structure stays the same (no LFS files, no zip), this issue is just moving the doc build repos from github to HF hub

@mishig25
Copy link
Contributor Author

mishig25 commented Oct 24, 2022

@coyotte508 at the moment, there is no zip. Would I need LFS ?, and if so, is there anything I need to do besides this step ?

@coyotte508
Copy link
Member

coyotte508 commented Oct 24, 2022

LFS will make the git repos a lot smaller in size so it should be beneficial in any case.

I didn't see the gitattributes :) What's left I guess is on the hub side, making sure to git lfs install after cloning the repos.

@mishig25
Copy link
Contributor Author

making sure to git lfs install after cloning the repos.

did so on the hub backend side 👍

@mishig25
Copy link
Contributor Author

mishig25 commented Oct 26, 2022

@coyotte508 I've actually switched to using zipped file.
When I tried on transformers docs builds (folder with files combined 95MB), hub_client was failing with:

File "/usr/local/lib/python3.8/site-packages/huggingface_hub/utils/_errors.py", line [21](https://github.com/huggingface/transformers/actions/runs/3319951930/jobs/5486173258#step:11:22)3, in hf_raise_for_status
    response.raise_for_status()
  File "/usr/local/lib/python3.8/site-packages/requests/models.py", line 1021, in raise_for_status
    raise HTTPError(http_error_msg, response=self)
requests.exceptions.HTTPError: 504 Server Error: Gateway Time-out for url: https://huggingface.co/datasets/hf-doc-build/doc-build-dev.git/info/lfs/objects/batch

cc: @Wauplin

When I zipped it into a zip file (14 MB), everything worked. You can find on the hub here

@mishig25
Copy link
Contributor Author

mishig25 commented Oct 4, 2023

all done

@mishig25 mishig25 closed this as completed Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants