Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hf_hub_download / snapshot_download as aliases in HfApi #1573

Closed
Wauplin opened this issue Jul 28, 2023 · 0 comments · Fixed by #1580
Closed

Add hf_hub_download / snapshot_download as aliases in HfApi #1573

Wauplin opened this issue Jul 28, 2023 · 0 comments · Fixed by #1580

Comments

@Wauplin
Copy link
Contributor

Wauplin commented Jul 28, 2023

Discussion triggered by @Narsil on slack (private link) cc @hysts. Let's keep the same naming to avoid confusion. A few args would be shared/defined at HfApi level (token, endpoint, user_agent,...). The main goal is to avoid passing those args all the time in a script (same as upload_file/upload_folder).

Implementation-wise, we need to implement endpoint parameter in hf_hub_download which is a long-requested feature anyway 😄 (#1082).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant