Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redundant assignment of URL in file_download.py #2435

Closed
fvarno opened this issue Aug 1, 2024 · 1 comment · Fixed by #2443
Closed

Redundant assignment of URL in file_download.py #2435

fvarno opened this issue Aug 1, 2024 · 1 comment · Fixed by #2443
Labels
bug Something isn't working

Comments

@fvarno
Copy link

fvarno commented Aug 1, 2024

Describe the bug

There is a redundant assignment in line 1739 of file_download.py.

url = url = ...

This is indeed not a bug but also obviously not intended and I couldn't find the correct label for raising it.

Reproduction

No response

Logs

No response

System info

Copy-and-paste the text below in your GitHub issue.

- huggingface_hub version: 0.23.2
- Platform: Linux-5.15.0-94-generic-x86_64-with-glibc2.35
- Python version: 3.10.14
- Running in iPython ?: No
- Running in notebook ?: No
- Running in Google Colab ?: No
- Token path ?: /home/farshid/.cache/huggingface/token
- Has saved token ?: True
- Who am I ?: farshidvarno
- Configured git credential helpers: 
- FastAI: N/A
- Tensorflow: N/A
- Torch: 2.4.0+cu118
- Jinja2: 3.1.3
- Graphviz: N/A
- keras: N/A
- Pydot: N/A
- Pillow: 10.2.0
- hf_transfer: N/A
- gradio: N/A
- tensorboard: N/A
- numpy: 1.26.3
- pydantic: N/A
- aiohttp: 3.9.5
- ENDPOINT: https://huggingface.co
- HF_HUB_CACHE: /home/farshid/.cache/huggingface/hub
- HF_ASSETS_CACHE: /home/farshid/.cache/huggingface/assets
- HF_TOKEN_PATH: /home/farshid/.cache/huggingface/token
- HF_HUB_OFFLINE: False
- HF_HUB_DISABLE_TELEMETRY: False
- HF_HUB_DISABLE_PROGRESS_BARS: None
- HF_HUB_DISABLE_SYMLINKS_WARNING: False
- HF_HUB_DISABLE_EXPERIMENTAL_WARNING: False
- HF_HUB_DISABLE_IMPLICIT_TOKEN: False
- HF_HUB_ENABLE_HF_TRANSFER: False
- HF_HUB_ETAG_TIMEOUT: 10
- HF_HUB_DOWNLOAD_TIMEOUT: 10
@fvarno fvarno added the bug Something isn't working label Aug 1, 2024
@Wauplin
Copy link
Contributor

Wauplin commented Aug 12, 2024

Thanks for noticing @fvarno! I fixed it in #2443

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants