Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: snapshot_download - add library_name and library_version #37

Closed
nreimers opened this issue May 6, 2021 · 1 comment · Fixed by #38
Closed

Feature request: snapshot_download - add library_name and library_version #37

nreimers opened this issue May 6, 2021 · 1 comment · Fixed by #38

Comments

@nreimers
Copy link

nreimers commented May 6, 2021

With cached_download() I can provide the library name & version, which is sent via http-agent.

For snapshot_download() I did not find such a function. For statistics reasons, it would be nice if you could also provide library_name and library_version. [And hopefully later get statistics which models are most frequently accessed from your library]

PS: Are the github issues the right place to propose wishes for features or should I put them somewhere else?

@LysandreJik
Copy link
Member

Thanks, @nreimers, the GitHub issues are definitely the right place to proposes your feature requests. You're right that library_name and library_version are currently missing on snapshot_download and that they should be added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants