Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty file suffix when optimizing or quantizing is not handled #364

Closed
2 of 4 tasks
ierezell opened this issue Aug 26, 2022 · 0 comments · Fixed by #363
Closed
2 of 4 tasks

Empty file suffix when optimizing or quantizing is not handled #364

ierezell opened this issue Aug 26, 2022 · 0 comments · Fixed by #363
Assignees
@echarlaix
Labels
bug Something isn't working

Comments

@ierezell
Copy link
Contributor

ierezell commented Aug 26, 2022 •
edited
Loading

System Info

latest master

Who can help?

@echarlaix

Information

  • The official example scripts
  • My own modified scripts

Tasks

  • An officially supported task in the examples folder (such as GLUE/SQuAD, ...)
  • My own task or dataset (give details below)

Reproduction

Optimize or quantize a model but user do not want a suffix so use :
file_suffix=None => RuntimeError
file_suffix="" => file_name like encoder_.onnx

Expected behavior

Have the same name as the original onnx file like encoder.onnx

#363 fixes that
@ierezell ierezell added the bug Something isn't working label Aug 26, 2022
@ierezell ierezell mentioned this issue Aug 26, 2022
Merged
@echarlaix echarlaix self-assigned this Aug 26, 2022
@ierezell ierezell changed the title Empty file suffix when optimizing is not handled Empty file suffix when optimizing or quantizing is not handled Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@echarlaix echarlaix

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(optimization): handle empty file suffix
2 participants
@ierezell @echarlaix