-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DoRA support for Embedding #1677
Comments
Indeed, DoRA is not supported for embeddings yet. Community contributions are welcome here, otherwise we may get to work on it some time in the future but there are no concrete plans yet. |
This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. |
We're eager to receive a PR from the community 🤗! I am also having this issue. |
Hey @BenjaminBossan I would like to try my hand at this. As I understand it, I would need to build the DoRA Embedding layer in |
Thanks a lot for offering to take this @ariG23498. Yes, you got it exactly right on how to add the layer. In case you need more context on why DoRA is implemented as it is (which looks more complicated than needed), you can check #1806, but this background info should not be needed to work on this. |
Feature request
Supporting DoRA with Embedding to allow seamless integration with the LoRA framework.
Motivation
I need to finetune a model where additional tokens have to be trained. But getting the "Embedding does not support DoRA yet, please set it to False" error.
Your contribution
No
The text was updated successfully, but these errors were encountered: