Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a guide to add a new fine-tuning method in the doc #2251

Closed
YF-T opened this issue Dec 3, 2024 · 2 comments
Closed

a guide to add a new fine-tuning method in the doc #2251

YF-T opened this issue Dec 3, 2024 · 2 comments

Comments

@YF-T
Copy link

YF-T commented Dec 3, 2024

Feature request

Hello, I am a researcher in the finetune area. Can you publish a guide to add a new fine-tuning method in the doc? I think researchers like me are glad to experiment their methods based on this repo.

Motivation

Researchers like me are glad to experiment their methods based on this repo, but don't know how to add.

Your contribution

Yes, but after verifying the feasibility of my method.

@BenjaminBossan
Copy link
Member

Thanks for the suggestion. Indeed, it would be great to have a step by step guide on how to add a new fine-tuning method to PEFT. We have a contribution guideline with some paragraphs on adding new methods, not sure if you saw that.

As mentioned, a good way to start is to check previous PRs. Just as an example of a recent PR adding a new method, check out #2172. Also, I typically recommend potential contributes to start with a draft PR that focuses on implementing the new method as a first step. Once this is reviewed, we can work on adding unit tests as a second step. The third step is then to add documentation and examples. Ideally, one of the examples is (similar to) an experiment from the paper, so that we can verify it works as expected.

Let me know if that helps or if you need more details. We can update the contribution guide based on that feedback.

@YF-T
Copy link
Author

YF-T commented Dec 4, 2024

Thank you for your patient reply! I will learn the guide and previous PRs.

@YF-T YF-T closed this as completed Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants