Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging AdaLora module with 8bit base model and 4bit basemodel #959

Closed
LokeshJatangi opened this issue Sep 26, 2023 · 2 comments
Closed

Comments

@LokeshJatangi
Copy link

Feature request

Hi @BenjaminBossan ,@younesbelkada, @pacman100

Support merging AdaLoRA adapters with base model when :

  1. base model is loaded in int8 .
  2. Base model loaded in 4bit using QLoRA method.

Motivation

  • This is helpful when the goal is to merge adapter weights for faster inference with 8bit model and 4bit model inference
  • Reduces memory usage when applying AdaLORA modules with LLMs like Falcon, LLAMA2 etc..

Your contribution

I am highly interested to add this feature to PEFT.
#875 and #851 PR's will be my reference for writing this PR.
Please suggests what unit tests needs to be added.
Also, provide your invaluable suggestions and pitfalls that I should avoid when implementing for AdaLoRA.

@BenjaminBossan
Copy link
Member

Thanks for offering to take this task.

Please suggests what unit tests needs to be added.

I think you can take inspiration from the two PRs you quoted for determining what tests to add.

Also, provide your invaluable suggestions and pitfalls that I should avoid when implementing for AdaLoRA.

Hard to anticipate this. I would suggest to just go ahead and start with 8bit and see how far you get. Create a draft PR as soon as you got something going and we can give you feedback based on that.

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

@github-actions github-actions bot closed this as completed Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants