Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Server stop functionality is unresponsive #140

Open
3manifold opened this issue Nov 12, 2024 · 0 comments · May be fixed by #138
Open

[Bug] Server stop functionality is unresponsive #140

3manifold opened this issue Nov 12, 2024 · 0 comments · May be fixed by #138

Comments

@3manifold
Copy link
Contributor

Description

It was observed that the server stop functionality during a KeyboardInterrupt in unresponsive. Ideally, stop functionality should work in both of the following scenarios (currently not the case):

  • Scenario 1:
    • start server -> stop server
  • Scenario 2:
    • start server -> start client -> stop server

Reproduce

An example scenario can be reproduced locally by following the steps below:

  1. python3 s2s_pipeline.py --recv_host 0.0.0.0 --send_host 0.0.0.0 # wait for server to start..
  2. kill -2 <server_PID> # send KeyboardInterrupt signal to server
  3. # server does not stop

This bug also relates to issue #139 . Implementation and a description of the fix can be found in pull request #138 .

@3manifold 3manifold linked a pull request Nov 12, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant