Skip to content

Commit a6a2924

Browse files
committed
typo
1 parent e6c45b6 commit a6a2924

File tree

3 files changed

+9
-9
lines changed

3 files changed

+9
-9
lines changed

.github/workflows/benchmark_v2.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ on:
2828
required: false
2929
type: string
3030
default: ''
31-
upload_to_hf:
31+
upload_to_hub:
3232
description: 'HuggingFace Dataset to upload results to (e.g., "org/benchmark-results")'
3333
required: false
3434
type: string
@@ -109,8 +109,8 @@ jobs:
109109
fi
110110
111111
# Add HuggingFace upload parameters if specified
112-
if [ -n "${{ inputs.upload_to_hf }}" ]; then
113-
args="$args --upload-to-hf '${{ inputs.upload_to_hf }}'"
112+
if [ -n "${{ inputs.upload_to_hub }}" ]; then
113+
args="$args --upload-to-hub '${{ inputs.upload_to_hub }}'"
114114
fi
115115
116116
if [ -n "${{ inputs.run_id }}" ]; then

.github/workflows/benchmark_v2_caller.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ jobs:
5252
measurement_iterations: ${{ inputs.measurement_iterations || 5 }}
5353
num_tokens_to_generate: ${{ inputs.num_tokens_to_generate || 100 }}
5454
commit_sha: ${{ github.sha }}
55-
upload_to_hf: true
55+
upload_to_hub: true
5656
run_id: ${{ github.run_id }}
5757
benchmark_repo_id: ahadnagy/transformers-benchmarks
5858
secrets: inherit

benchmark_v2/run_benchmarks.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -467,7 +467,7 @@ def main():
467467

468468
# Upload results to HuggingFace Dataset if requested
469469
upload_run_id = None
470-
if args.upload_to_hf:
470+
if args.upload_to_hub:
471471
logger.info("=" * 60)
472472
logger.info("UPLOADING TO HUGGINGFACE DATASET")
473473
logger.info("=" * 60)
@@ -476,7 +476,7 @@ def main():
476476
upload_run_id = upload_results_to_hf_dataset(
477477
output_dir=args.output_dir,
478478
summary_file=summary_file,
479-
dataset_name=args.upload_to_hf,
479+
dataset_name=args.upload_to_hub,
480480
run_id=effective_run_id,
481481
logger=logger
482482
)
@@ -498,11 +498,11 @@ def main():
498498
logger.info(f"Output directory: {args.output_dir}")
499499
logger.info(f"Summary report: {summary_file}")
500500

501-
if args.upload_to_hf:
501+
if args.upload_to_hub:
502502
if upload_run_id:
503-
logger.info(f"HuggingFace Dataset: {args.upload_to_hf}")
503+
logger.info(f"HuggingFace Dataset: {args.upload_to_hub}")
504504
logger.info(f"Run ID: {upload_run_id}")
505-
logger.info(f"View results: https://huggingface.co/datasets/{args.upload_to_hf}/tree/main/{datetime.now().strftime('%Y-%m-%d')}/runs/{upload_run_id}")
505+
logger.info(f"View results: https://huggingface.co/datasets/{args.upload_to_hub}/tree/main/{datetime.now().strftime('%Y-%m-%d')}/runs/{upload_run_id}")
506506
else:
507507
logger.warning("Upload to HuggingFace Dataset failed")
508508

0 commit comments

Comments
 (0)