Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old links to CDN #10744

Merged
merged 1 commit into from
Mar 16, 2021
Merged

Remove old links to CDN #10744

merged 1 commit into from
Mar 16, 2021

Conversation

sgugger
Copy link
Collaborator

@sgugger sgugger commented Mar 16, 2021

What does this PR do?

This PR removes a few links left pointing to https://cdn.huggingface.co instead of https://huggingface.co (purely cosmetic since they are not actually used anymore, normally).

@sgugger sgugger requested a review from LysandreJik March 16, 2021 14:39
Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sgugger sgugger merged commit b549258 into master Mar 16, 2021
@sgugger sgugger deleted the herbert_tokenizer_files branch March 16, 2021 14:48
@julien-c
Copy link
Member

those are not valid files though (check the url template for the other models)

sgugger added a commit that referenced this pull request Mar 16, 2021
@sgugger sgugger mentioned this pull request Mar 16, 2021
@sgugger
Copy link
Collaborator Author

sgugger commented Mar 16, 2021

Oopsie, thanks for flagging!

sgugger added a commit that referenced this pull request Mar 16, 2021
Iwontbecreative pushed a commit to Iwontbecreative/transformers that referenced this pull request Jul 15, 2021
Iwontbecreative pushed a commit to Iwontbecreative/transformers that referenced this pull request Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants