-
Notifications
You must be signed in to change notification settings - Fork 27.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fixup/style] requires TF but doesn't say that cleanly #11570
Comments
The same thing happens with flax. |
This should take care of all the deps:
Please let us know if it didn't. |
I don't think we need a new script for that. Maybe add the check inside the script that fails ( |
Also with a bit of some further massaging of |
Note that this specific script only relies on the model backends only, so no need for the whole of dev yet. |
If it's easier - then by all means. I just thought that if we already maintain |
It looks like
make fixup
et al, require tf (and pt), but fail in unexpected way when the requirements are missing:Thank you, @michaelbenayoun for flagging this
Should we add a small script first that checks all the requirements so that the error is not misleading, but something like: "need to install
pip install -e .[dev]
to developtransformers
"?@sgugger, @LysandreJik
The text was updated successfully, but these errors were encountered: