Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Flax] Change all shift_tokens_right to numpy code #12719

Closed
patrickvonplaten opened this issue Jul 14, 2021 · 0 comments · Fixed by #12720
Closed

[Flax] Change all shift_tokens_right to numpy code #12719

patrickvonplaten opened this issue Jul 14, 2021 · 0 comments · Fixed by #12720
Assignees

Comments

@patrickvonplaten
Copy link
Contributor

shift labels right is called usually in the data collator and therefore should not be written in jax, but in numpy to not block the TPU. We should make sure that all Encoder-Decoder models have their shift_tokens_right implemented in numpy as it's faster.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant