Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Consistency] Make sure all xxxForSequenceClassification models support problem_type #13370

Closed
NielsRogge opened this issue Sep 1, 2021 · 2 comments

Comments

@NielsRogge
Copy link
Contributor

NielsRogge commented Sep 1, 2021

A while ago (#11012), an additional attribute called problem_type has been added to xxxForSequenceClassification models, which you can set to "multi_label_classification", "single_label_classification" or "regression" to fine-tune xxxForSequenceClassification models for the respective problem. This makes sure the appropriate loss function is used.

This is great, however, 3 things need to be improved in my opinion:

  • this is causing a bit of an inconsistency as it's not implemented in all models which have an xxxForSequenceClassification head model.
  • it's also not included in any of the CookieCutter templates, which are used to add new models.
  • this is not documented anywhere.

cc @abhishekkrthakur

@abhishekkrthakur
Copy link
Member

Pretty sure it is documented :)
https://huggingface.co/transformers/main_classes/configuration.html

Agree that its not in cookie-cutter and its not implemented for all models (it cannot be implemented for all). :)

image

@github-actions
Copy link

github-actions bot commented Oct 1, 2021

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants