Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic Inputs for fx traced GPTNeoLM #14633

Closed
sdtblck opened this issue Dec 5, 2021 · 3 comments
Closed

Dynamic Inputs for fx traced GPTNeoLM #14633

sdtblck opened this issue Dec 5, 2021 · 3 comments

Comments

@sdtblck
Copy link

sdtblck commented Dec 5, 2021

🚀 Feature request

I've been looking a little into using torch.fx + HF lately, and run into a problem that the traced GPTNeoLM can't take dynamic inputs - would love to know what work would be needed to enable that, and what the current blockers are - it would be great to be able to use the traced module for inference.

I'm assuming the problem has something to do with caching of keys/values?

Your contribution

Given guidance, I could put some work into adding this feature, yes :)

@LysandreJik
Copy link
Member

cc @michaelbenayoun

@michaelbenayoun
Copy link
Member

Hi @sdtblck ,
The issue with dynamic inputs is not related to the past_key_values but to dynamic control-flow in the model forward pass implementation. The PR #14321, that I plan to merge at some point (hopefully before the end of the year) solves this kind of issues for the supported models.

@github-actions
Copy link

github-actions bot commented Jan 5, 2022

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants