Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto_find_batch_size should say what batch size it is using #21950

Closed
p-christ opened this issue Mar 4, 2023 · 4 comments
Closed

auto_find_batch_size should say what batch size it is using #21950

p-christ opened this issue Mar 4, 2023 · 4 comments
Assignees

Comments

@p-christ
Copy link

p-christ commented Mar 4, 2023

Feature request

When using auto_find_batch_size=True in the trainer I believe it identifies the right batch size but then it doesn't log it to the console anywhere?

It would be good if it could log what batch size it is using?

Motivation

I'd like to know what batch size it is using because then I will know roughly how big a batch can fit in memory - this info would be useful elsewhere.

Your contribution

N/A

@sgugger
Copy link
Collaborator

sgugger commented Mar 6, 2023

cc @muellerzr

@muellerzr muellerzr self-assigned this Mar 6, 2023
@p-christ
Copy link
Author

p-christ commented Mar 6, 2023

Also, it would be good if auto find batch size also worked for the eval batch size? Otherwise for the eval batch size I still have to guess a few times and hope I don't run out of memory?

@muellerzr
Copy link
Contributor

Thanks! Solved with #23800

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants