Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FastTokenizer for LLaMa #22114

Closed
theblackcat102 opened this issue Mar 12, 2023 · 3 comments
Closed

FastTokenizer for LLaMa #22114

theblackcat102 opened this issue Mar 12, 2023 · 3 comments

Comments

@theblackcat102
Copy link
Contributor

Feature request

FastTokenizer support for LLaMa sentencepiece tokenizer.

Motivation

The offset_mapping is only available in FastTokenizer, it would be useful if there's support for this.

Your contribution

I have tried using existing sentencepiece based model as replacement. However hf conversation code means we are missing the byte fallback support

The sentencepiece tokenizer that you are converting to a fast tokenizer uses the byte fallback option which is not implemented in the fast tokenizers

Which means out of vocabulary tokens are simply mapped to instead of using the byte mapping inside the vocab.

@sgugger
Copy link
Collaborator

sgugger commented Mar 13, 2023

Let's maybe wait for the LLaMa PR to be merged first?

@dongs0104
Copy link

it is fix on tokenizers

huggingface/tokenizers#1183

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@github-actions github-actions bot closed this as completed May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants