Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] duplicate sentences in document_question_answering.mdx #23729

Closed
jungnerd opened this issue May 24, 2023 · 2 comments · Fixed by #23735
Closed

[docs] duplicate sentences in document_question_answering.mdx #23729

jungnerd opened this issue May 24, 2023 · 2 comments · Fixed by #23735

Comments

@jungnerd
Copy link
Contributor

Description

There are duplicate sentences in document_question_answering.mdx from line number 40 to 45.

Document / Language

document_question_answering.mdx / en

Suggestion

Capture 20230524_1541@2x
should be either:

candidate 1 candidate 2

(...), to predict the positions of the start and end tokens of the answer. (...)

(...), in order to predict which token is at the start of the answer and which token is at the end of the answer. (...)

Please let me know which of the two candidates you would prefer.

@sgugger
Copy link
Collaborator

sgugger commented May 24, 2023

I'd prefer candidate 1 personally. Thanks for reporting and looking forward to your PR with a fix!

@jungnerd
Copy link
Contributor Author

Thanks for your feedback and I agree that candidate 1 is better. I opened PR #23735.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants