Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix custom architectures #28983

Closed
not-lain opened this issue Feb 12, 2024 · 4 comments
Closed

Fix custom architectures #28983

not-lain opened this issue Feb 12, 2024 · 4 comments
Labels
Feature request Request for a new feature WIP Label your PR/Issue with WIP for some long outstanding Issues/PRs that are work in progress

Comments

@not-lain
Copy link
Contributor

not-lain commented Feb 12, 2024

opening this issue for better visibility and to keep track to what needs to be fixed, any contributions are welcome.

name issue pull request comment
dependency issue when working with a custom architecture in a repo that has a dot in its name #28919 #29175 fixed
wrongly annotated configuration when saving a model that has a custom pipeline #28907 #29004 awaiting review
add push_to_hub( ) method when working with pipelines #28857 #29172 awaiting review
@not-lain
Copy link
Contributor Author

@Rocketknight1 this might help with keeping track to everything.
I'm going to start working on the 2nd issue above hope I fix it soon.

@amyeroberts amyeroberts added Feature request Request for a new feature WIP Label your PR/Issue with WIP for some long outstanding Issues/PRs that are work in progress labels Mar 24, 2024
@huggingface huggingface deleted a comment from github-actions bot Mar 24, 2024
@not-lain
Copy link
Contributor Author

@amyeroberts just for clarification.

  • the second issue is all about when a repo has a custom pipeline and then (let's say for example you finetune the model and push the new model to another repo) the custom pipeline breaks down when loaded from the final repo.
  • the push_to_hub method to pipelines is self explanatory, I have reread this for some time now, and I think I am beginning to understand where they're coming from coz the pipelines library is built on top of a model, and again I agree that that should be put for another day since it is irrelevant for now, allowing people to easily push their pipelines takes priority for now.

@not-lain
Copy link
Contributor Author

apologies for failing to notice most of the stuff (i made some some wrong assumptions about the {repo_id}--{module} tag and it mislead both me and the maintainers at the beginning), so i wanted to give you a clarified update for what i came out with hope this helps you out

@not-lain
Copy link
Contributor Author

all done 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature request Request for a new feature WIP Label your PR/Issue with WIP for some long outstanding Issues/PRs that are work in progress
Projects
None yet
Development

No branches or pull requests

2 participants